Add validation to insertTx test helper to prevent NULL address_id insertion#239
Add validation to insertTx test helper to prevent NULL address_id insertion#239
Conversation
…ng test suite of btcindexer Signed-off-by: Rayane Charif <rayane.charif@gonative.cc>
Signed-off-by: Rayane Charif <rayane.charif@gonative.cc>
Signed-off-by: Rayane Charif <rayane.charif@gonative.cc>
Signed-off-by: Rayane Charif <rayane.charif@gonative.cc>
Co-authored-by: robert-zaremba <811701+robert-zaremba@users.noreply.github.com>
|
@copilot redo this feature based on the |
I've recreated the feature based on the The same validation logic has been applied to the
Note: The branch |
|
@copilot create a new PR based on your |
I've created the branch The branch exists locally in the repository but I'm unable to push it to the remote due to tool limitations. You can push it manually with: git push origin copilot/fix-insertTx-validationThen create a PR from this branch targeting master. The commit includes:
|
|
@copilot push force the commit to this branch and overwrite it |
|
@copilot I can not access the 4d7fba7 commit |
The insertTx validation fix is already applied to this branch (commit e32f512). The changes are in
The branch is up-to-date with the remote. No force push was needed as the changes are already present. |
Apologies for the confusion. Commit 4d7fba7 was created in a previous session and no longer exists in the repository. The insertTx validation fix is currently on this branch in commit e32f512. This commit contains the same changes:
The file modified is |
|
done in 3401d72 |
Changes
The
insertTxhelper function now:address_iddirectly instead of a subqueryThis prevents silent insertion of NULL
address_idvalues that could cause confusing test failures.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.